lkml.org 
[lkml]   [2007]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/5 -v2] Added generic lg.h in the include/linux directory
    Hi Steven,

    I am just being pedantic here (and I should have beaten up on Rusty
    before now ... :-)

    On Thu, 09 Aug 2007 00:36:30 -0400 Steven Rostedt <rostedt@goodmis.org>
    wrote:
    >
    > --- a/include/asm-i386/lg.h
    > +++ b/include/asm-i386/lg.h
    > @@ -1,5 +1,5 @@
    > -#ifndef _LGUEST_H
    > -#define _LGUEST_H
    > +#ifndef _I386_LGUEST_H
    > +#define _I386_LGUEST_H

    Maybe _ASM_LG_H or _I386_LG_H ? And there is a comment on the #endif at
    the end of the file that should match.

    > +++ b/include/linux/lg.h
    > @@ -0,0 +1,30 @@
    > +#ifndef _LINUX_LGUEST_H
    > +#define _LINUX_LGUEST_H

    Maybe _LINUX_LG_H ?

    Also (this is for Rusty) include/linux/lguest.h is protected by
    _ASM_LGUEST_H ...

    --
    Cheers,
    Stephen Rothwell sfr@canb.auug.org.au
    http://www.canb.auug.org.au/~sfr/
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2007-08-09 07:41    [W:0.022 / U:1.336 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site