lkml.org 
[lkml]   [2007]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [2.6.22.2 review 09/84] Fix rfkill IRQ flags.
    On Tue, Aug 07, 2007 at 11:37:06PM +0200, Jan Engelhardt wrote:
    >
    > On Aug 7 2007 13:43, Greg KH wrote:
    > >
    > >added this 64-bit bug:
    > >
    > > ....
    > > unsigned int flags;
    > >
    > > spin_lock_irqsave(&task->lock, flags);
    > > ....
    > >
    > >irq 'flags' must be unsigned long, not unsigned int. The -rt tree has
    > >strict checks about this on 64-bit so this triggered a build failure.
    >
    > Since the check is a compile-time one, would not it be good to add
    > it to the regular linux tree too?

    BUILD_BUG_ON was tried, but due to amazingly wrong moment of merging
    survived only for a day or so. There will be a second try, though.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-09 07:27    [W:0.020 / U:1.396 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site