Messages in this thread Patch in this message | | | From | "Subbaiah Venkata" <> | Subject | [PATCH] lib/sort.c, 2.6.22 kernel | Date | Wed, 8 Aug 2007 16:19:55 -0700 |
| |
Hello, I fixed and tested a small bug in lib/sort.c file, heap sort function.
The fix avoids unnecessary swap of contents when i is 0 (saves few loads and stores), which happens every time sort function is called. I felt the fix is worth bringing it to your attention given the importance and frequent use of the sort function.
Thank you all.
================================================================== diff --git a/lib/sort.c b/lib/sort.c index 9615678..6abbaf3 100644 --- a/lib/sort.c +++ b/lib/sort.c @@ -67,7 +67,7 @@ void sort(void *base, size_t num, size_t size, }
/* sort */ - for (i = n - size; i >= 0; i -= size) { + for (i = n - size; i > 0; i -= size) { swap(base, base + i, size); for (r = 0; r * 2 + size < i; r = c) { c = r * 2 + size; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |