Messages in this thread | | | Date | Wed, 8 Aug 2007 11:40:31 -0700 | From | "Nish Aravamudan" <> | Subject | Re: Make checkpatch warn about pointless casting of kalloc returns. |
| |
On 8/8/07, jschopp <jschopp@austin.ibm.com> wrote: > > > > + WARN("No need to cast return value.\n"); > > > > > > Could the warning be more descriptive? This describes what, but it should also describe > > > why; after all if somebody made this error they may not know they why. > > > > I'm open to suggestions.. > > How about > > WARN("No need to cast return value, it is unnecessary and can hide real bugs. See > http://c-faq.com/malloc/mallocnocast.html for more details\n");
That's a long line. Can it be split into two? Otherwise seems sane.
Thanks, Nish - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |