Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH 18/25] [PATCH] turn priviled operations into macros in entry.S | Date | Wed, 8 Aug 2007 16:11:24 +0200 |
| |
On Wednesday 08 August 2007 15:58:06 Glauber de Oliveira Costa wrote:
> On 8/8/07, Andi Kleen <ak@suse.de> wrote: > > > > > +#define SYSRETQ \ > > > + movq %gs:pda_oldrsp,%rsp; \ > > > + swapgs; \ > > > + sysretq; > > > > When the macro does more than sysret it should have a different > > name > That's fair. Again, suggestions are welcome. Maybe SYSCALL_RETURN ?
Sounds reasonable.
> > > retint_restore_args: > > > - cli > > > + DISABLE_INTERRUPTS(CLBR_ANY) > > > > Similar. > I don't think so. They are live here, but restore_args follows, so we > can safely clobber anything here. Right?
The non argument registers cannot be clobbered.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |