lkml.org 
[lkml]   [2007]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
FromAndi Kleen <>
SubjectRe: [PATCH 3/25] [PATCH] irq_flags / halt routines
DateWed, 8 Aug 2007 11:14:19 +0200

> +#ifdef CONFIG_PARAVIRT
> +#include <asm/paravirt.h>
> +# ifdef CONFIG_X86_VSMP
> +static inline int raw_irqs_disabled_flags(unsigned long flags)
> +{
> + return !(flags & X86_EFLAGS_IF) || (flags & X86_EFLAGS_AC);
> +}
> +# else
> +static inline int raw_irqs_disabled_flags(unsigned long flags)
> +{
> + return !(flags & X86_EFLAGS_IF);
> +}
> +# endif

You should really turn the vsmp special case into a paravirt client first
instead of complicating all this even more.

> +#ifndef CONFIG_PARAVIRT
> +#define raw_safe_halt native_raw_safe_halt
> +#define halt native_halt
> +#endif /* ! CONFIG_PARAVIRT */

This seems inconsistent

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-08 12:07    [from the cache]
©2003-2010