[lkml]   [2007]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH/RFT] finish i386 and x86-64 sysdata conversion
On 8/7/07, Jeff Garzik <> wrote:
> Yinghai Lu wrote:
> > the sysdata stuff try to fix:
> > when calgary iommu code was introduced, it is trying to share sysdata
> > that orginally is initialized k8_bus.c and used by pcibus_to_node. but
> > that only happen with AMD K8 platform. and have nothing to do with
> > calgary.
> incorrect: sysdata is initialized when the structure is created, which
> clearly not only in k8_bus.c

before his first patch, numa juse use sysdata pointer for node.

> > Then my patch get_mp_bus_to_node_as_early will use that sysdata as
> > node as early as possible before the pci_scan bus is called.
> that's incorrect, since it assumes NUMA owns ->sysdata

At that time, only it use that.

> > then Mul came out his patch split the sharing that will never happen.
> that's incorrect, ->sysdata will be shared among Calgary, NUMA, and
> PCI-domain support.

but not the same time on run time system with Calgary, NUMA.

> > Also i don't think anyone test muli sysdata patch with amd64 platform
> > with acpi=off. even muli himself.
> I did. I did all PCI domain support development on AMD64 platform.

really, but his first patch is broken with acpi=off.
I guess you tested his patch plus your patch. instead of test his
patch barely. I tested his patch + my patch, and it works well, and
even test his patch only.

> > calgary support bus numa at this time? i mean mult peer root bus on
> > different node..
> My PCI domains patch add support for multiple peer root buses. That's
> the definition of PCI domain support.
> Branch 'pciseg' of
> git://

good, i will look at it.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2007-08-08 03:31    [W:0.061 / U:2.744 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site