Messages in this thread | | | Date | Tue, 7 Aug 2007 14:10:30 +0200 | From | Cornelia Huck <> | Subject | Re: [PATCH] request_firmware: skip timeout if userspace was not notified |
| |
On Tue, 7 Aug 2007 13:46:55 +0200, "Kay Sievers" <kay.sievers@vrfy.org> wrote:
> > - Use an extra parameter in which successful delivery can be indicated. > > Make this > > int kobject_uevent_env_check(struct kobject *kobject, > > enum kobject_action action, > > char *envp[], int delivered); > > so existing callers that don't care don't have to be changed. > > How do you check if events have been "handled"? None of the recent > distros uses /sbin/hotplug anymore. Netlink events are broadcasted, > but no failure in delivery doesn't mean anything like "handled", or > delivered to the right instance. Even if you check that the netlink > socket has listeners, that wouldn't be sufficient to tell that is is > handled.
You can't check if it's been handled, yes; but you can certainly check if you delivered it. I guess Javier wants to exclude the cases where userspace didn't have any chance to handle it.
Javier: Do you have an idea how common the case "we broadcasted, but nobody listened so we got a timeout" is? If the usual reason for the timeout is that firmware was requested before a listener showed up, I'm not sure whether that check is worth it... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |