lkml.org 
[lkml]   [2007]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] lro: eHEA example how to use LRO
    Date
    Hi Auke,

    On Friday 03 August 2007 22:29, Kok, Auke wrote:
    > Jan-Bernd Themann wrote:
    > > This patch shows how the generic LRO interface is used for SKB mode
    > >
    > > Signed-off-by: Jan-Bernd Themann <themann@de.ibm.com>
    > >
    > > ---
    > > drivers/net/Kconfig | 1 +
    > > drivers/net/ehea/ehea.h | 9 ++++-
    > > drivers/net/ehea/ehea_ethtool.c | 15 +++++++
    > > drivers/net/ehea/ehea_main.c | 84 +++++++++++++++++++++++++++++++++++---
    > > 4 files changed, 101 insertions(+), 8 deletions(-)
    > >
    > > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
    > > index f8a602c..fec4004 100644
    > > --- a/drivers/net/Kconfig
    > > +++ b/drivers/net/Kconfig
    >
    > <snip>
    >
    > > +module_param(use_lro, int, 0);
    >
    > Have you looked at my generic lro get/set patch that I posted this week? this
    > adds a useless module parameter while ethtool has all the structure already to
    > accomodate setting lro on/off.
    >

    Yes, I saw your patch. Looks very good to me. I will modify our driver soon
    to use ethtool instead of this module parameter.

    Thanks for adding this support to the ethtool interface.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-06 09:35    [W:0.031 / U:0.212 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site