lkml.org 
[lkml]   [2007]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [2/2] 2.6.23-rc2: known regressions with patches
Date
From
> > Caused-By       : Thomas Renninger <trenn@suse.de>
> > commit 29b71a1ca74491fab9fed09e9d835d840d042690

> A patch was sent to Tony. AFAIK it got accepted, not sure whether it
> already is in any and which git tree...

The suggested patch adds manual padding to the acpi_device_id structure
definition in include/linux/mod_devicetable.h I didn't take it, and it
appears that nobody else did either. It is not in Linus' tree (as of 2.6.23-rc2).

I expressed doubts about whether this is the right fix. The problem
is that when cross-compiling a locally compiled utility makes a size &
alignment check. This is bogus. We shouldn't care whether this structure
compiles to the same size/alignment as the kernel that will use on the
target platform.

Is fixing this the right way (make the scripts/mod/file2alias.c understand
target alignment rules in a cross environment) just too hideous to
contemplate ... and we should just sacrifice 7 bytes of padding in
order to keep life simple?

-Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-06 20:49    [W:0.035 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site