lkml.org 
[lkml]   [2007]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sonypi: Fix initialization warning
Thomas Renninger wrote:
> On Sun, 2007-08-05 at 21:05 +0200, Richard Knutsson wrote:
>
>> Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
>> ---
>> Got this from the compiler (gcc (GCC) 4.1.2 20070626 (Red Hat 4.1.2-13)):
>> drivers/char/sonypi.c:1153: warning: initialization from incompatible pointer type
>>
>>
>> diff --git a/drivers/char/sonypi.c b/drivers/char/sonypi.c
>> index 73037a4..2dcd519 100644
>> --- a/drivers/char/sonypi.c
>> +++ b/drivers/char/sonypi.c
>> @@ -1147,10 +1147,15 @@ static int sonypi_acpi_remove(struct acpi_device *device, int type)
>> return 0;
>> }
>>
>> +static const struct acpi_device_id sonypi_acpi_driver_ids[] = {
>> + {ACPI_PROCESSOR_HID, 0},
>>
> This is wrong. You need to take the HID the driver should match for, in
> this case: {"SNY6001", 0 },
>
Oh bugger, a cut 'n' paste error...
Thanks for reviewing it.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-05 22:07    [W:0.048 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site