Messages in this thread Patch in this message | | | Date | Sun, 5 Aug 2007 19:36:03 +0400 | From | Oleg Nesterov <> | Subject | [PATCH] zap_other_threads: don't optimize thread_group_empty() case |
| |
Nowadays thread_group_empty() and next_thread() are simple list operations, this optimization doesn't make sense: we are doing exactly same check one line below.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- t/kernel/signal.c~4_ZOT 2007-08-03 21:11:59.000000000 +0400 +++ t/kernel/signal.c 2007-08-05 19:28:13.000000000 +0400 @@ -987,9 +987,6 @@ void zap_other_threads(struct task_struc p->signal->flags = SIGNAL_GROUP_EXIT; p->signal->group_stop_count = 0; - if (thread_group_empty(p)) - return; - for (t = next_thread(p); t != p; t = next_thread(t)) { /* * Don't bother with already dead threads - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |