Messages in this thread Patch in this message | | | From | Jesper Juhl <> | Subject | [PATCH][RESEND] improve scripts/gcc-version.sh output a bit when called without args | Date | Sat, 4 Aug 2007 20:30:42 +0200 |
| |
(Resend of patch from 7 May 2007 17:18:00)
Currently, if you call scripts/gcc-version.sh without arguments it will generate this output :
$ sh scripts/gcc-version.sh scripts/gcc-version.sh: line 12: [: =: unary operator expected scripts/gcc-version.sh: line 16: -E: command not found scripts/gcc-version.sh: line 17: -E: command not found 0000
Not too pretty. I believe this is an improvement :
$ sh scripts/gcc-version.sh Error: No compiler specified. Usage: scripts/gcc-version.sh <gcc-command>
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com> ---
scripts/gcc-version.sh | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/scripts/gcc-version.sh b/scripts/gcc-version.sh index 8a1d187..a5121a6 100644 --- a/scripts/gcc-version.sh +++ b/scripts/gcc-version.sh @@ -9,10 +9,16 @@ # gcc-2.95.3, `030301' for gcc-3.3.1, etc. # -if [ $1 = "-p" ] ; then with_patchlevel=1; shift; fi +if [[ $1 = "-p" ]] ; then with_patchlevel=1; shift; fi compiler="$*" +if [ ${#compiler} -eq 0 ]; then + echo "Error: No compiler specified." + echo -e "Usage:\n\t$0 <gcc-command>" + exit 1 +fi + MAJOR=$(echo __GNUC__ | $compiler -E -xc - | tail -n 1) MINOR=$(echo __GNUC_MINOR__ | $compiler -E -xc - | tail -n 1) if [ "x$with_patchlevel" != "x" ] ; then
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |