lkml.org 
[lkml]   [2007]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: sata_via: write errors on PATA drive connected to VT6421
    On Sat, 1 Sep 2007 00:55:21 +0200
    Ondrej Zary <linux@rainbow-software.org> wrote:

    > Hello,
    > I think that I've found and fixed the problem. There is a copy/paste bug in
    > vt6421_set_dma_mode() function which causes wrong values to be written to
    > PATA_UDMA_TIMING register.
    >
    >
    > This patch fixes a copy/paste bug that breaks DMA modes on VT6421 PATA port.
    >
    > Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
    >
    > --- linux-2.6.22.3-orig/drivers/ata/sata_via.c 2007-09-01 00:40:22.000000000 +0200
    > +++ linux-2.6.22.3-router2/drivers/ata/sata_via.c 2007-09-01 00:10:40.000000000 +0200
    > @@ -370,7 +370,7 @@
    > {
    > struct pci_dev *pdev = to_pci_dev(ap->host->dev);
    > static const u8 udma_bits[] = { 0xEE, 0xE8, 0xE6, 0xE4, 0xE2, 0xE1, 0xE0, 0xE0 };
    > - pci_write_config_byte(pdev, PATA_UDMA_TIMING, udma_bits[adev->pio_mode - XFER_UDMA_0]);
    > + pci_write_config_byte(pdev, PATA_UDMA_TIMING, udma_bits[adev->dma_mode - XFER_UDMA_0]);
    > }
    >
    > static const unsigned int svia_bar_sizes[] = {

    Acked-by: Alan Cox <alan@redhat.com>

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-09-01 01:13    [W:0.020 / U:2.464 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site