lkml.org 
[lkml]   [2007]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [-mm PATCH] Memory controller improve user interface (v2)
    On 9/1/07, Andrew Morton <akpm@linux-foundation.org> wrote:
    > On Fri, 31 Aug 2007 00:22:46 +0530
    > Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
    >
    > > +/*
    > > + * Strategy routines for formating read/write data
    > > + */
    > > +int mem_container_read_strategy(unsigned long long val, char *buf)
    > > +{
    > > + return sprintf(buf, "%llu Bytes\n", val);
    > > +}
    >
    > It's a bit cheesy to be printing the units like this. It's better to just
    > print the raw number.
    >
    > If you really want to remind the user what units that number is in (not a
    > bad idea) then it can be encoded in the filename, like
    > /proc/sys/vm/min_free_kbytes, /proc/sys/vm/dirty_expire_centisecs, etc.
    >

    Sounds good, I'll change the file to memory.limit_in_bytes and
    memory.usage_in_bytes.

    >
    > > +int mem_container_write_strategy(char *buf, unsigned long long *tmp)
    > > +{
    > > + *tmp = memparse(buf, &buf);
    > > + if (*buf != '\0')
    > > + return -EINVAL;
    > > +
    > > + printk("tmp is %llu\n", *tmp);
    >
    > don't think we want that.
    >

    Yes, I'll redo the patch and resend.

    > > + /*
    > > + * Round up the value to the closest page size
    > > + */
    > > + *tmp = ((*tmp + PAGE_SIZE - 1) >> PAGE_SHIFT) << PAGE_SHIFT;
    > > + return 0;
    > > +}

    Thanks,
    Balbir
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-31 23:57    [W:0.032 / U:217.232 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site