Messages in this thread | | | Date | Fri, 31 Aug 2007 11:26:42 -0400 | From | "Dmitry Torokhov" <> | Subject | Re: [PATCH] input: Silence 'unused variable' warning in iforce joystick driver |
| |
Hi Jesper,
On 8/30/07, Jesper Juhl <jesper.juhl@gmail.com> wrote: > On 31/08/2007, Satyam Sharma <satyam@infradead.org> wrote: > ... > > > > Hmm, would this not still give a warning when JOYSTICK_IFORCE_USB=y? > > Arrgh, I messed that one up real good... Thank you for your keen eye Satyam :-) > > > > [ I didn't know mixing code and declarations (not at top of statement > > block) was accepted style in the kernel ... ] > > > It's not the common case, but this is certainly not the only place in the kernel where we do it. > > > > IMHO either you should at least wrap that case inside a {} of its > > own (so that the int status; is at top of a statement block), or else, > > Yeah, I should... > > > preferably, just add "__maybe_unused" to the first declaration that you > > removed just now. > > > > Here's an updated patch that actually works as intended. >
I had a similar patch from Andrew Morton in my queue and it just got merged. There should be no warning anymore.
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |