lkml.org 
[lkml]   [2007]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] fix ALSA compilation on Sparc32
    At Thu, 30 Aug 2007 11:09:39 +0100,
    Alan Cox wrote:
    >
    > On Thu, 30 Aug 2007 11:26:04 +0200
    > Markus Dahms <mad@automagically.de> wrote:
    >
    > > The dma_alloc_coherent and dma_free_coherent function seem to be not
    > > available on sparc(32) architecture. It is not used by SBus sound
    > > drivers, so it's disabled via #ifndef for CONFIG_SPARC32.
    >
    > It would probably look a lot cleaner if you either provided dummy
    > dma_alloc_coherent/free coherent inlines for SPARC32, fixed it (if
    > sparc32 can do coherent DMA) or if you must ifdef it provide dummy
    > functions in the memalloc code so its a single ifdef

    It's been indeed inline on 2.6.22 or ealier in
    include/asm-generic/dma-mapping.h, but it's changed to extern without
    defining functions.

    I don't think it's a good idea to have function declarations even
    though we surely know that there are no real function definitions...


    Takashi
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-30 12:55    [W:0.023 / U:159.320 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site