lkml.org 
[lkml]   [2007]   [Aug]   [30]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
    /
    DateThu, 30 Aug 2007 22:20:23 +0200
    From"Jesper Juhl" <>
    SubjectRe: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver
    On 30/08/2007, Daniel Drake <dsd@gentoo.org> wrote:
    > Jesper Juhl wrote:
    > > Since kmalloc() returns a void pointer there is no reason to cast
    > > its return value.
    > > This patch also removes a pointless initialization of a variable.
    >
    > NAK: adds a sparse warning
    > zd_chip.c:116:15: warning: implicit cast to nocast type
    >
    Ok, I must admit I didn't check with sparse since it seemed pointless
    - we usually never cast void pointers to other pointer types,
    specifically because the C language nicely guarantees that the right
    thing will happen without the cast.  Sometimes we have to cast them to
    integer types, su sure we need the cast there.   But what on earth
    makes a "zd_addr_t *" so special that we have to explicitly cast a
    "void *" to that type?
    
    I see it's defined as
      typedef u32 __nocast zd_addr_t;
    in drivers/net/wireless/zd1211rw/zd_types.h , but why the __nocast ?
    
    What would be wrong in applying my patch that removes the cast of the
    kmalloc() return value and then also remove the "__nocast" here?
    
    
    -- 
    Jesper Juhl <jesper.juhl@gmail.com>
    Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
    Plain text mails only, please      http://www.expita.com/nomime.html
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    
    
    \
     
     \ /
      Last update: 2007-08-30 22:23    [from the cache]
    ©2003-2008