Messages in this thread | | | Date | Wed, 29 Aug 2007 13:33:30 -0500 | From | jschopp <> | Subject | Re: [PATCH 2.6.23] ibmebus: Prevent bus_id collisions |
| |
> + len = strlen(dn->full_name + 1); > + bus_len = min(len, BUS_ID_SIZE - 1); > + memcpy(dev->ofdev.dev.bus_id, dn->full_name + 1 > + + (len - bus_len), bus_len); > + for (i = 0; i < bus_len; i++) > + if (dev->ofdev.dev.bus_id[i] == '/') > + dev->ofdev.dev.bus_id[i] = '_'; > > /* Register with generic device framework. */ > if (ibmebus_register_device_common(dev, dn->name) != 0) {
What happens when the full name is > 31 characters? It looks to me that it will be truncated, which takes away the uniqueness guarantee.
There must be an individual property that is guaranteed to be unique and less than 32 characters. How about "ibm,my-drc-index"? That looks like a good candidate. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |