lkml.org 
[lkml]   [2007]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] trivial - constify sched.h
    Joe Perches napsal(a):
    > Add const to some struct task_struct * uses

    Does this have any impact on generated code? What (some objdumps or something)?
    Or more descriptive log, why is this about to be done, please.

    >
    > Signed-off-by: Joe Perches <joe@perches.com>
    >
    > ---
    >
    > include/linux/sched.h | 24 ++++++++++++------------
    > 1 files changed, 12 insertions(+), 12 deletions(-)
    >
    > diff --git a/include/linux/sched.h b/include/linux/sched.h
    > index ba78807..71d40a1 100644
    > --- a/include/linux/sched.h
    > +++ b/include/linux/sched.h
    > @@ -1222,22 +1222,22 @@ static inline int rt_prio(int prio)
    > return 0;
    > }
    >
    > -static inline int rt_task(struct task_struct *p)
    > +static inline int rt_task(const struct task_struct *p)
    > {
    > return rt_prio(p->prio);
    > }
    >
    > -static inline pid_t process_group(struct task_struct *tsk)
    > +static inline pid_t process_group(const struct task_struct *tsk)
    > {
    > return tsk->signal->pgrp;
    > }
    >
    > -static inline pid_t signal_session(struct signal_struct *sig)
    > +static inline pid_t signal_session(const struct signal_struct *sig)
    > {
    > return sig->__session;
    > }
    >
    > -static inline pid_t process_session(struct task_struct *tsk)
    > +static inline pid_t process_session(const struct task_struct *tsk)
    > {
    > return signal_session(tsk->signal);
    > }
    > @@ -1247,22 +1247,22 @@ static inline void set_signal_session(struct signal_struct *sig, pid_t session)
    > sig->__session = session;
    > }
    >
    > -static inline struct pid *task_pid(struct task_struct *task)
    > +static inline struct pid *task_pid(const struct task_struct *task)
    > {
    > return task->pids[PIDTYPE_PID].pid;
    > }
    >
    > -static inline struct pid *task_tgid(struct task_struct *task)
    > +static inline struct pid *task_tgid(const struct task_struct *task)
    > {
    > return task->group_leader->pids[PIDTYPE_PID].pid;
    > }
    >
    > -static inline struct pid *task_pgrp(struct task_struct *task)
    > +static inline struct pid *task_pgrp(const struct task_struct *task)
    > {
    > return task->group_leader->pids[PIDTYPE_PGID].pid;
    > }
    >
    > -static inline struct pid *task_session(struct task_struct *task)
    > +static inline struct pid *task_session(const struct task_struct *task)
    > {
    > return task->group_leader->pids[PIDTYPE_SID].pid;
    > }
    > @@ -1275,7 +1275,7 @@ static inline struct pid *task_session(struct task_struct *task)
    > * If pid_alive fails, then pointers within the task structure
    > * can be stale and must not be dereferenced.
    > */
    > -static inline int pid_alive(struct task_struct *p)
    > +static inline int pid_alive(const struct task_struct *p)
    > {
    > return p->pids[PIDTYPE_PID].pid != NULL;
    > }
    > @@ -1286,7 +1286,7 @@ static inline int pid_alive(struct task_struct *p)
    > *
    > * Check if a task structure is the first user space task the kernel created.
    > */
    > -static inline int is_init(struct task_struct *tsk)
    > +static inline int is_init(const struct task_struct *tsk)
    > {
    > return tsk->pid == 1;
    > }
    > @@ -1639,7 +1639,7 @@ extern void wait_task_inactive(struct task_struct * p);
    > * all we care about is that we have a task with the appropriate
    > * pid, we don't actually care if we have the right task.
    > */
    > -static inline int has_group_leader_pid(struct task_struct *p)
    > +static inline int has_group_leader_pid(const struct task_struct *p)
    > {
    > return p->pid == p->tgid;
    > }
    > @@ -1650,7 +1650,7 @@ static inline struct task_struct *next_thread(const struct task_struct *p)
    > struct task_struct, thread_group);
    > }
    >
    > -static inline int thread_group_empty(struct task_struct *p)
    > +static inline int thread_group_empty(const struct task_struct *p)
    > {
    > return list_empty(&p->thread_group);
    > }
    >
    >



    --
    Jiri Slaby (jirislaby@gmail.com)
    Faculty of Informatics, Masaryk University
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-27 23:29    [W:0.032 / U:209.376 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site