lkml.org 
[lkml]   [2007]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] SLUB use cmpxchg_local
    From
    Date
    On Tue, 2007-08-21 at 16:14 -0700, Christoph Lameter wrote:
    > On Tue, 21 Aug 2007, Mathieu Desnoyers wrote:
    >
    > > - Changed smp_rmb() for barrier(). We are not interested in read order
    > > across cpus, what we want is to be ordered wrt local interrupts only.
    > > barrier() is much cheaper than a rmb().
    >
    > But this means a preempt disable is required. RT users do not want that.
    > Without preemption the processor can be moved after c has been determined.
    > That is why the smp_rmb() is there.

    Likewise for disabling interrupts, we don't like that either. So
    anything that requires cpu-pinning is preferably not done.

    That said, we can suffer a preempt-off section if its O(1) and only a
    few hundred cycles.

    The trouble with all this percpu data in slub is that it also requires
    pinning to the cpu in much of the slow path, either that or what we've
    been doing so far with slab, a lock per cpu, and just grab one of those
    locks and stick to the data belonging to that lock, regardless of
    whether we get migrated.

    slab-rt has these locks for all allocations and they are a massive
    bottleneck for quite a few workloads, getting a fast path allocation
    without using these would be most welcome.

    So, if the fast path can be done with a preempt off, it might be doable
    to suffer the slow path with a per cpu lock like that.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-27 08:55    [W:4.090 / U:1.752 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site