Messages in this thread | | | Date | Sun, 26 Aug 2007 18:36:18 +0300 | From | Ville Syrjälä <> | Subject | Re: [PATCH] atyfb: remove dead code |
| |
On Sun, Aug 26, 2007 at 11:12:37AM +0200, Olaf Hering wrote: > Remove dead code. > > Signed-off-by: Olaf Hering <olaf@aepfle.de> > > --- > drivers/video/aty/atyfb_base.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > --- a/drivers/video/aty/atyfb_base.c > +++ b/drivers/video/aty/atyfb_base.c > @@ -2767,8 +2767,7 @@ static int atyfb_blank(int blank, struct > if (par->lock_blank || par->asleep) > return 0; > > -#ifdef CONFIG_FB_ATY_BACKLIGHT > -#elif defined(CONFIG_FB_ATY_GENERIC_LCD) > +#ifdef CONFIG_FB_ATY_GENERIC_LCD > if (par->lcd_table && blank > FB_BLANK_NORMAL && > (aty_ld_lcd(LCD_GEN_CNTL, par) & LCD_ON)) { > u32 pm = aty_ld_lcd(POWER_MANAGEMENT, par);
This will change the behavior of the code. I basically agree with the change because the current code will not control the backlight when the kernel is built with CONFIG_FB_ATY_BACKLIGHT but the system doesn't support the backlight interface (ie. non-pmac system). However someone should check that it doesn't cause problems for pmac users.
-- Ville Syrjälä syrjala@sci.fi http://www.sci.fi/~syrjala/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |