Messages in this thread | | | Date | Sat, 25 Aug 2007 19:59:01 -0400 (EDT) | From | "Robert P. J. Day" <> | Subject | Re: [PATCH 09/30] mtd: Don't cast kmalloc() return value in drivers/mtd/maps/pmcmsp-flash.c |
| |
On Sun, 26 Aug 2007, Jesper Juhl wrote:
> On 24/08/07, Robert P. J. Day <rpjday@mindspring.com> wrote:
> > actually, i would think kcalloc would be more appropriate here, no? > > > > Why? > > msp_parts[i] = kzalloc(pcnt * sizeof(struct mtd_partition), GFP_KERNEL); > > seems better to me than > > msp_parts[i] = kcalloc(1, pcnt * sizeof(struct mtd_partition), GFP_KERNEL);
i was thinking more along the lines of
msp_parts[i] = kcalloc(pcnt, sizeof(struct mtd_partition), GFP_KERNEL);
which was kind of the obvious implication, no? unless there's a reason kcalloc() wouldn't work here, this is pretty much what kcalloc() was designed for.
rday
-- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA
http://crashcourse.ca ======================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |