lkml.org 
[lkml]   [2007]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Sort module list - use ppos instead of m->private
    On Fri, 24 Aug 2007 11:39:33 -0400
    Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:

    > Sort modules list - use ppos instead of m->private
    >
    > When reading the data by small chunks (i.e. byte by byte), the index (ppos) is
    > incremented by seq_read() directly and no "next" callback is called when going
    > to the next module.
    >
    > Therefore, use ppos instead of m->private to deal with the fact that this index
    > is incremented directly to pass to the next module in seq_read() after the
    > buffer has been emptied.

    Confused. What problem is this patch fixing? I'm guessing that something
    is going wrong when /proc/modules is read one-byte-at-a-time?

    <tests that>

    <nope>

    Better changelogs, please.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-25 01:39    [W:2.343 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site