lkml.org 
[lkml]   [2007]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] /drivers/char sx.c ioremap -> pci_ioremap api
    On 8/24/07, Scott Thompson <postfailathushmail@gmail.com> wrote:
    >
    > patchset against 2.6.23-rc3.
    >
    > moves the iomap/iounmap call to pci 'flavor'. this was a
    > recommendation from a previously submitted patch that handles
    > the unchecked iomap (or, now, pci_iomap) return code.
    >
    > Signed-off-by: Scott Thompson <postfail <at> hushmail.com>
    > ----------------------------------------------------------
    >
    > diff --git a/drivers/char/sx.c b/drivers/char/sx.c
    > index 85a2328..481334f 100644
    > --- a/drivers/char/sx.c
    > +++ b/drivers/char/sx.c
    > @@ -2626,14 +2626,14 @@ static void __devinit fix_sx_pci(struct pci_dev
    > *pdev, struct sx_board *board)
    >
    > pci_read_config_dword(pdev, PCI_BASE_ADDRESS_0, &hwbase);
    > hwbase &= PCI_BASE_ADDRESS_MEM_MASK;
    > - rebase = ioremap(hwbase, 0x80);

    remove also the hwbase var.

    > + rebase = pci_iomap(pdev, 0, 0x80);
    > t = readl(rebase + CNTRL_REG_OFFSET);
    > if (t != CNTRL_REG_GOODVALUE) {
    > printk(KERN_DEBUG "sx: performing cntrl reg fix: %08x -> "
    > "%08x\n", t, CNTRL_REG_GOODVALUE);
    > writel(CNTRL_REG_GOODVALUE, rebase + CNTRL_REG_OFFSET);
    > }
    > - iounmap(rebase);
    > + pci_iounmap(pdev, rebase);
    > }
    > #endif
    >


    --
    http://www.fi.muni.cz/~xslaby/ Jiri Slaby
    faculty of informatics, masaryk university, brno, cz
    e-mail: jirislaby gmail com, gpg pubkey fingerprint:
    B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-24 21:03    [W:0.022 / U:119.760 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site