lkml.org 
[lkml]   [2007]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH v2 -mm 3/7] I/OAT: code cleanup from checkpatch output
Date
From
Randy Dunlap [mailto:randy.dunlap@oracle.com] 
>Sent: Thursday, August 23, 2007 10:39 PM
>To: Nelson, Shannon
>Cc: akpm@linux-foundation.org; linux-kernel@vger.kernel.org;
>davem@davemloft.net
>Subject: Re: [PATCH v2 -mm 3/7] I/OAT: code cleanup from
>checkpatch output
>
>On Thu, 23 Aug 2007 17:15:06 -0700 Shannon Nelson wrote:
>
>> Take care of a bunch of little code nits in ioatdma files
>>
>> Signed-off-by: Shannon Nelson <shannon.nelson@intel.com>
>> Acked-by: David S. Miller <davem@davemloft.net>
>> ---
>>
>> drivers/dma/ioat_dma.c | 200
>+++++++++++++++++++++++++++---------------------
>> 1 files changed, 111 insertions(+), 89 deletions(-)
>>
>> diff --git a/drivers/dma/ioat_dma.c b/drivers/dma/ioat_dma.c
>> index 55227d4..9a4d154 100644
>> --- a/drivers/dma/ioat_dma.c
>> +++ b/drivers/dma/ioat_dma.c
>
>> - printk(KERN_INFO "Intel(R) I/OAT DMA Engine found, %d
channels\n",
>> - device->common.chancnt);
>> + printk(KERN_INFO " "
>> + "ioatdma: Intel(R) I/OAT DMA Engine found, %d
channels\n",
>> + device->common.chancnt);
>>
>> err = ioat_self_test(device);
>> if (err)
>
>> @@ -764,7 +784,8 @@ err_set_dma_mask:
>> pci_disable_device(pdev);
>> err_enable_device:
>>
>> - printk(KERN_ERR "Intel(R) I/OAT DMA Engine initialization
failed\n");
>> + printk(KERN_INFO " "
>> + "ioatdma: Intel(R) I/OAT DMA Engine initialization
failed\n");
>>
>> return err;
>> }
>
>What's with these (KERN_INFO " "
> "...more strings");
>??

These are admittedly not the smartest move, but they are replaced later
in the patch-set.
sln
--
======================================================================
Mr. Shannon Nelson LAN Access Division, Intel Corp.
Shannon.Nelson@intel.com I don't speak for Intel
(503) 712-7659 Parents can't afford to be squeamish.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-24 18:41    [W:0.054 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site