Messages in this thread | | | Date | Thu, 23 Aug 2007 13:12:32 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r |
| |
On Thu, 23 Aug 2007, Segher Boessenkool wrote: > > This simply isn't true. The compiler *can* combine asm stuff:
Please Segher, just shut up.
The combining, which I've mentioned *multiple*times* is
if (atomic_read(&x) <= 1)
and dammit, if that doesn't result in a *single* instruction, the code generation is pure and utter crap.
It should result in
cmpl $1,offset(reg)
and nothing else. And there is no way in hell you are doing that with "atomic_read()" being inline asm.
So can you now just go away?
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |