lkml.org 
[lkml]   [2007]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH resubmit] /drivers/ata ioremap returncode check
    On 21:42 Thu 23 Aug 2007, Alexey Dobriyan wrote:
    > On Wed, Aug 22, 2007 at 10:34:58PM -0700, Brandon Philips wrote:
    > > On 19:47 Wed 22 Aug 2007, Scott Thompson wrote:
    > > > Patchset against 2.6.23-rc3. corrects missing ioremap return
    > > > checks, resending after making changes suggested....
    > > >
    > > > Signed-off-by: Scott Thompson <postfail <at> hushmail.com>
    > > > ------------------------------------------------------------
    > > > diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c
    > > > index 4ca7fd6..8dc7c3b 100644
    > > > --- a/drivers/ata/pata_ixp4xx_cf.c
    > > > +++ b/drivers/ata/pata_ixp4xx_cf.c
    > > > @@ -189,6 +189,10 @@ static __devinit int ixp4xx_pata_probe(struct platform_device *pdev)
    > > > data->cs0 = devm_ioremap(&pdev->dev, cs0->start, 0x1000);
    > > > data->cs1 = devm_ioremap(&pdev->dev, cs1->start, 0x1000);
    > > >
    > > > + if (!data->cs0 || !data->cs1) {
    > > > + return -ENOMEM;
    > > > + }
    > > > +
    > >
    > > You aren't following the Kernel CodingStyle there.
    > >
    > > See Documentation/CodingStyle:
    > >
    > > "Do not unnecessarily use braces where a single statement will do."
    > >
    > > + if (!data->cs0 || !data->cs1)
    > > + return -ENOMEM;
    >
    > This and nice printk message absence. :)

    Huh? What do you mean?

    Thanks,

    Brandon
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-23 19:57    [W:4.757 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site