lkml.org 
[lkml]   [2007]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [uml-devel] [PATCH 6/6] UML - Fix hostfs style
Date
On sabato 18 agosto 2007, Satyam Sharma wrote:
> On Fri, 17 Aug 2007, Jeff Dike wrote:
> > Style fixes in hostfs.

> > @@ -328,17 +326,17 @@ int hostfs_readdir(struct file *file, vo
> > [...]
> > - if(error) break;
> > + if (error) break;
>
> if (error)
> break;
>
> > @@ -522,28 +523,28 @@ static int init_inode(struct inode *inod
> > [...]
> > else type = OS_TYPE_DIR;
>
> I wonder what's the generally accepted / followed coding style for this,
> actually. Personally I'd prefer:
>
> else
> type = OS_TYPE_DIR;

I strongly agree with this style; beyond style itself, one strong reason is
that joining statements hinder singlestepping through function code (it's
easy to run gdb on UML, and anyway kgdb exists).

Bye
--
"Doh!" (cit.), I've made another mistake!
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2007-08-23 16:57    [W:0.506 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site