lkml.org 
[lkml]   [2007]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][bugzilla #8679] therm_throt.c: Fix section mismatch


On Thu, 23 Aug 2007, Satyam Sharma wrote:
>
> I must say, this is an amazingly cunning idea. Only things I can think of
> against this would be: the dropping of unneeded code is not guaranteed,
> but depends on compiler. And we saw from the "static inline {return 0;}"
> testcase that gcc can sometimes be not-so-smart.

Oh, wait. I just stumbled upon arch/i386/kernel/cpu/intel_cacheinfo.c
that references the callback function from generic CPU-initialization
startup code that must get executed even when HOTPLUG_CPU=n. The leave-it-
upto-toolchain method would see this reference, and preserve the function
even after initcalls stage for HOTPLUG_CPU=n. So the explicit __cpuinit
method scores here, admittedly only because of weird taste of said code.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-22 23:49    [W:0.277 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site