Messages in this thread | | | Date | Thu, 23 Aug 2007 02:40:51 +0530 | From | Balbir Singh <> | Subject | Re: [BUG] 2.6.23-rc3-mm1 - kernel BUG at net/core/skbuff.c:95! |
| |
Kay Sievers wrote: > On Thu, 2007-08-23 at 00:34 +0530, Balbir Singh wrote: >> Kay Sievers wrote: >>>> gargh, sorry, that's probably due to my screwed up attempt to fix Kay's >>>> screwed up >>>> gregkh-driver-driver-core-change-add_uevent_var-to-use-a-struct.patch. >>>> >>>> Kay sent an update patch but it didn't arrive in time. >>>> >>>> Greg, if you haven't yet merged that, please do so asap? >>>> >>>> So what _should_ this: >>>> >>>> --- a/arch/powerpc/kernel/vio.c~fix-4-gregkh-driver-driver-core-change-add_uevent_var-to-use-a-struct >>>> +++ a/arch/powerpc/kernel/vio.c >>>> @@ -373,7 +373,7 @@ static int vio_hotplug(struct device *de >>>> dn = dev->archdata.of_node; >>>> if (!dn) >>>> return -ENODEV; >>>> - cp = of_get_property(dn, "compatible", &length); >>>> + cp = of_get_property(dn, "compatible", &env->buflen); >>>> if (!cp) >>>> return -ENODEV; >>>> >>>> _ >>>> >>>> have done? >>> Does replacing "&length" with "NULL" work? That's what's in the updated >>> patch. > >> replacing &length with NULL does not work for me. I get a message saying that >> init terminated with signal 7. > > Hi Balbir, > ugh, I can't see what's going wrong here. >
Same here.. I went through the new add_uevent_var() code. The only change I found was that instead of using env->envp[env->envp_idx] as an argument to vsnprintf(), the code looks semantically the same. Even with those changes, the assignment of env->envp[env->envp_idx++] to &env->buf[ env->buflen] makes the semantics look similar.
I verified that the arguments to add_uevent_var() are sane. So at this point, I am a little lost. I'll debug further and see if the socket allocation is sufficient.
> Care to just "return 0" for the whole function, and try again? Just to > rule out that this is the cause of the problem. > > Thanks, > Kay >
-- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |