lkml.org 
[lkml]   [2007]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.23-rc3-mm1: kgdb build failure on powerpc
    On Wed, 22 Aug 2007 21:04:28 +0200
    Mariusz Kozlowski <m.kozlowski@tuxland.pl> wrote:

    > Hello,
    >
    > Got that on imac g3.
    >
    > CC kernel/kgdb.o
    > kernel/kgdb.c: In function 'kgdb_handle_exception':
    > kernel/kgdb.c:940: error: invalid lvalue in unary '&'
    > kernel/kgdb.c:940: warning: type defaults to 'int' in declaration of '_o_'
    > kernel/kgdb.c:940: error: invalid lvalue in unary '&'
    > kernel/kgdb.c:940: warning: type defaults to 'int' in declaration of '_n_'
    > kernel/kgdb.c:940: error: invalid lvalue in unary '&'
    > kernel/kgdb.c:940: error: invalid lvalue in unary '&'
    > kernel/kgdb.c:940: error: invalid lvalue in unary '&'
    > kernel/kgdb.c:940: warning: type defaults to 'int' in declaration of 'type name'
    > make[1]: *** [kernel/kgdb.o] Blad 1
    > make: *** [kernel] Blad 2
    >

    I'm not surprised.

    while (cmpxchg(&atomic_read(&debugger_active), 0, (procid + 1)) != 0) {

    a) cmpxchg isn't available on all architectures

    b) we can't just go and take the address of atomic_read()'s return value!

    c) that's pretty ugly-looking stuff anyway.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-22 21:51    [W:4.139 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site