lkml.org 
[lkml]   [2007]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[2.6.20.17 review 32/58] fs: 9p/conv.c error path fix
    When buf_check_overflow() returns != 0 we will hit kfree(ERR_PTR(err))
    and it will not be happy about it.

    Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    fs/9p/conv.c | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/fs/9p/conv.c b/fs/9p/conv.c
    index a3ed571..923d75c 100644
    --- a/fs/9p/conv.c
    +++ b/fs/9p/conv.c
    @@ -742,6 +742,7 @@ struct v9fs_fcall *v9fs_create_twrite(u32 fid, u64 offset, u32 count,
    if (err) {
    kfree(fc);
    fc = ERR_PTR(err);
    + goto error;
    }

    if (buf_check_overflow(bufp)) {
    --
    1.5.2.5
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-22 11:29    [W:0.025 / U:87.572 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site