lkml.org 
[lkml]   [2007]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] autofs4: reinstate negatitive timeout of mount fails
    From
    Date
    On Tue, 2007-08-21 at 13:15 -0700, Andrew Morton wrote:
    > On Tue, 21 Aug 2007 17:26:09 +0800
    > Ian Kent <raven@themaw.net> wrote:
    >
    > > Due to a change to fs/dcache.c:d_lookup() in the 2.6 kernel whereby only
    > > hashed dentrys are returned the negative caching of mount failures
    > > stopped working in the autofs4 module for nobrowse mount (ie. directory
    > > created at mount time and removed at umount or following a mount
    > > failure).
    > >
    > > This patch keeps track of the dentrys from mount fails in order to be
    > > able check the timeout since the last fail and return the appropriate
    > > status. In addition the timeout value is settable at load time as a
    > > module option and via sysfs using the module
    > > parameter /sys/module/autofs4/parameters/negative_timeout.
    >
    > Boy, that's a complex-looking patch. I think I'll sit on this one
    > for 2.6.24 ;)

    Yes, that's fine .. the principle isn't that complex.

    >
    > It seems to use a lot of list_for_each[_safe] which could
    > have been coded as list_for_each_entry[_safe], btw.

    Mmm .. good point. I've not noticed the list_for_each_entry* macros.

    Ian


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-22 04:59    [W:0.035 / U:150.984 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site