lkml.org 
[lkml]   [2007]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 02/20] hwmon: (smsc47m1) restore missing name attribute
    -stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Jean Delvare <khali@linux-fr.org>

    The smsc47m1 driver no longer creates the name attribute used by
    libsensors to identify chip types. It was lost during the conversion
    to a platform driver. I was fooled by the fact that we do have a
    group with all attributes, but only to delete them all at once. The
    group is not used to create the attributes, so we have to explicitly
    create the name attribute.

    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Signed-off-by: Mark M. Hoffman <mhoffman@lightlink.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/hwmon/smsc47m1.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/hwmon/smsc47m1.c
    +++ b/drivers/hwmon/smsc47m1.c
    @@ -585,6 +585,8 @@ static int __devinit smsc47m1_probe(stru

    if ((err = device_create_file(dev, &dev_attr_alarms)))
    goto error_remove_files;
    + if ((err = device_create_file(dev, &dev_attr_name)))
    + goto error_remove_files;

    data->class_dev = hwmon_device_register(dev);
    if (IS_ERR(data->class_dev)) {
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-21 08:55    [W:0.021 / U:0.632 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site