lkml.org 
[lkml]   [2007]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/4] Fix mainline filesystems to handle ATTR_KILL_ bits correctly
    Jeff Layton wrote:
    > This should fix all of the filesystems in the mainline kernels to handle
    > ATTR_KILL_SUID and ATTR_KILL_SGID correctly. For most of them, this is
    > just a matter of making sure that they call generic_attrkill early in
    > the setattr inode op.
    >
    > Signed-off-by: Jeff Layton <jlayton@redhat.com>
    > ---
    > fs/xfs/linux-2.6/xfs_iops.c | 5 ++++-
    > --- a/fs/xfs/linux-2.6/xfs_iops.c
    > +++ b/fs/xfs/linux-2.6/xfs_iops.c
    > @@ -651,12 +651,15 @@ xfs_vn_setattr(
    > struct iattr *attr)
    > {
    > struct inode *inode = dentry->d_inode;
    > - unsigned int ia_valid = attr->ia_valid;
    > + unsigned int ia_valid;
    > bhv_vnode_t *vp = vn_from_inode(inode);
    > bhv_vattr_t vattr = { 0 };
    > int flags = 0;
    > int error;
    >
    > + generic_attrkill(inode->i_mode, attr);
    > + ia_valid = attr->ia_valid;
    > +
    > if (ia_valid & ATTR_UID) {
    > vattr.va_mask |= XFS_AT_UID;
    > vattr.va_uid = attr->ia_uid;

    Looks reasonable to me for XFS.
    Acked-by: Tim Shimmin <tes@sgi.com>

    So before, this clearing would happen directly in notify_change()
    and now this won't happen until notify_change() calls i_op->setattr
    which for a particular fs it can call generic_attrkill() to do it.
    So I guess for the cases where i_op->setattr is called outside of
    via notify_change, we don't normally have ATTR_KILL_SUID/SGID
    set so that nothing will happen there?
    I guess just wondering the effect with having the code on all
    setattr's. (I'm not familiar with the code path)

    --Tim
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-21 07:57    [W:0.023 / U:29.456 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site