lkml.org 
[lkml]   [2007]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [Git Patch] ACPI: Fix a warning of discarding qualifiers from pointer target type
    On Tue, Aug 21, 2007 at 07:14:49PM +0400, Alexey Starikovskiy wrote:
    > WANG Cong wrote:
    > > Fix this warning:
    > >
    > > drivers/acpi/ec.c: In function `acpi_ec_ecdt_probe':
    > > drivers/acpi/ec.c:873: warning: passing arg 1 of `acpi_get_devices' discards qualifiers from pointer target type
    > >
    > > (I don't know whether this fix hits the real problem.)
    > >
    > It is safe to give acpi_get_devices() const string, as it should not
    > modify it in any condition.

    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    ---
    diff --git a/drivers/acpi/namespace/nsxfeval.c b/drivers/acpi/namespace/nsxfeval.c
    index ab65b2c..f39fbc6 100644
    --- a/drivers/acpi/namespace/nsxfeval.c
    +++ b/drivers/acpi/namespace/nsxfeval.c
    @@ -540,7 +540,7 @@ acpi_ns_get_device_callback(acpi_handle obj_handle,
    ******************************************************************************/

    acpi_status
    -acpi_get_devices(char *HID,
    +acpi_get_devices(const char *HID,
    acpi_walk_callback user_function,
    void *context, void **return_value)
    {
    diff --git a/include/acpi/acpixf.h b/include/acpi/acpixf.h
    index b5cca5d..3d7ab9e 100644
    --- a/include/acpi/acpixf.h
    +++ b/include/acpi/acpixf.h
    @@ -130,7 +130,7 @@ acpi_walk_namespace(acpi_object_type type,
    void *context, void **return_value);

    acpi_status
    -acpi_get_devices(char *HID,
    +acpi_get_devices(const char *HID,
    acpi_walk_callback user_function,
    void *context, void **return_value);

    diff --git a/include/acpi/acstruct.h b/include/acpi/acstruct.h
    index aeb4498..8848265 100644
    --- a/include/acpi/acstruct.h
    +++ b/include/acpi/acstruct.h
    @@ -146,7 +146,7 @@ struct acpi_init_walk_info {
    struct acpi_get_devices_info {
    acpi_walk_callback user_function;
    void *context;
    - char *hid;
    + const char *hid;
    };

    union acpi_aml_operands {
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-08-21 17:21    [W:4.007 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site