lkml.org 
[lkml]   [2007]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [patch 12/23] local_t m32r use architecture specific cmpxchg_local
    Hello,

    From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
    Subject: [patch 12/23] local_t m32r use architecture specific cmpxchg_local
    Date: Mon, 20 Aug 2007 16:15:31 -0400
    > On m32r, use the new cmpxchg_local as primitive for the local_cmpxchg
    > operation.
    >
    > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
    > CC: takata@linux-m32r.org
    > CC: linux-m32r@ml.linux-m32r.org
    > ---
    > include/asm-m32r/local.h | 362 ++++++++++++++++++++++++++++++++++++++++++++++-
    > 1 file changed, 361 insertions(+), 1 deletion(-)

    I think this patch looks fine.

    Acked-by: Hirokazu Takata <takata@linux-m32r.org>

    BTW, I need an additional patch to fix a build error,
    caused by the above patch.

    -- Takata


    [PATCH] m32r: build fix of arch/m32r/kernel/smpboot.c

    This patch is for Mathieu Desnoyers's include/asm-m32r/local.h.
    Applying the new include/asm-m32r/local.h, inclusion of linux/sched.h
    is needed to fix a build error of arch/m32r/kernel/smpboot.c.

    <-- snip -->
    ...
    CC arch/m32r/kernel/smpboot.o
    /project/m32r-linux/kernel/work/linux-2.6_dev.git/arch/m32r/kernel/smpboot.c: In function 'do_boot_cpu':
    /project/m32r-linux/kernel/work/linux-2.6_dev.git/arch/m32r/kernel/smpboot.c:279: error: implicit declaration of function 'fork_idle'
    /project/m32r-linux/kernel/work/linux-2.6_dev.git/arch/m32r/kernel/smpboot.c:279: warning: assignment makes pointer from integer without a cast
    /project/m32r-linux/kernel/work/linux-2.6_dev.git/arch/m32r/kernel/smpboot.c:283: error: dereferencing pointer to incomplete type
    /project/m32r-linux/kernel/work/linux-2.6_dev.git/arch/m32r/kernel/smpboot.c:289: error: dereferencing pointer to incomplete type
    /project/m32r-linux/kernel/work/linux-2.6_dev.git/arch/m32r/kernel/smpboot.c:290: error: implicit declaration of function 'task_thread_info'
    /project/m32r-linux/kernel/work/linux-2.6_dev.git/arch/m32r/kernel/smpboot.c:290: error: invalid type argument of '->'
    /project/m32r-linux/kernel/work/linux-2.6_dev.git/arch/m32r/kernel/smpboot.c: In function 'start_secondary':
    /project/m32r-linux/kernel/work/linux-2.6_dev.git/arch/m32r/kernel/smpboot.c:429: error: implicit declaration of function 'cpu_init'
    make[2]: *** [arch/m32r/kernel/smpboot.o] Error 1
    <-- snip -->

    Signed-off-by: Hirokazu Takata <takata@linux-m32r.org>
    ---
    arch/m32r/kernel/smpboot.c | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/arch/m32r/kernel/smpboot.c b/arch/m32r/kernel/smpboot.c
    index 9dae410..b41aa78 100644
    --- a/arch/m32r/kernel/smpboot.c
    +++ b/arch/m32r/kernel/smpboot.c
    @@ -43,6 +43,7 @@
    #include <linux/init.h>
    #include <linux/kernel.h>
    #include <linux/mm.h>
    +#include <linux/sched.h>
    #include <linux/err.h>
    #include <linux/irq.h>
    #include <linux/bootmem.h>
    --
    1.5.2.4
    --
    Hirokazu Takata <takata@linux-m32r.org>
    Linux/M32R Project: http://www.linux-m32r.org/
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-21 11:59    [W:0.025 / U:0.696 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site