lkml.org 
[lkml]   [2007]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] type safe allocator


On Thu, 2 Aug 2007, Miklos Szeredi wrote:
>
> The number of variations can be reduced to just zeroing/nonzeroing, by
> making the array length mandatory. That's what glib does in g_new().

Quite frankly, you don't need the zeroing. That's what __GFP_ZERO does in
the flags.

That said, I'm not at all sure that it's at all more readable to add some
new abstraction layer and do

struct random_struct *ptr;

ptr = alloc_struct(random_struct, 1, GFP_KERNEL | __GFP_ZERO);
than just doing a

ptr = kmalloc(sizeof(*ptr), GFP_KERNEL | __GFP_ZERO);
or

ptr = kzalloc(sizeof(*ptr), GFP_KERNEL);

(and adding the zeroing variant of alloc_struct() just adds *more*
confusing issues).

The fact is, type safety in this area is probably less important than the
code just being readable. And have fifteen different interfaces to memory
allocation just isn't ever going to readable - regardless of how good they
are individually.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-02 19:27    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site