Messages in this thread | | | Date | Sat, 18 Aug 2007 23:03:51 +0400 | From | Oleg Nesterov <> | Subject | Re: + proc-export-a-processes-resource-limits-via-proc-pid.patch added to -mm tree |
| |
On 08/18, Neil Horman wrote: > > +static int proc_pid_limits(struct task_struct *task, char *buffer) > +{ > + unsigned int i; > + int count = 0; > + unsigned long flags; > + char *bufptr = buffer; > + > + struct rlimit rlim[RLIM_NLIMITS]; > + > + read_lock(&tasklist_lock); > + lock_task_sighand(task, &flags); > + if (task->signal == NULL){ > + unlock_task_sighand(task, &flags); > + read_unlock(&tasklist_lock);
Neil, please, don't add tasklist_lock again. It was not easy to wipe it from fs/proc/ :) Just change this code to use rcu_read_lock().
Oleg.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |