lkml.org 
[lkml]   [2007]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] include linux/types.h in if_fddi.h
On Thu, Aug 09, 2007 at 05:36:39PM +0100, Maciej W. Rozycki wrote:
> On Thu, 9 Aug 2007, Olaf Hering wrote:
>
> > include/linux/if_fddi.h is an exported header.
> > It uses __be16. Include linux/types.h to get this prototype.
>
> Please note that for userland it does not matter. With glibc you should
> include <netinet/if_fddi.h> which does the necessary bits before including
> <linux/if_fddi.h>. Any other C library should likely take a similar
> approach.

It doesn't make any sense to habe all libc's figure out inter-header
dependencies.

For each userspace exported header file an #include <linux/foo.h> should
always compile, and if it fails due to missing #include's in the header
that's a bug that should be fixed.

> It still seems right for Linux itself though.
>
> Maciej

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-18 20:17    [W:0.053 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site