lkml.org 
[lkml]   [2007]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware
    Date
    On Friday 17 August 2007, Kay Sievers wrote:
    >
    > > I'm not the one who's advocating a change here.  If you want to
    > > first change/break and then fix things, all of that is up to you.
    >
    > I'm happy to do that. Patch is attached.

    NAK. That wasn't even a serious attempt at the "fix" part,
    though it does the "break" part well enough to cause severe
    regressions.

    (As well as leaving all my technical points about your pushback
    un-addressed. As I noted before, the evident fact that you don't
    have technical responses to them says to me that your pushback
    has no real technical basis ...)


    Out of around 300 platform drivers in the tree (and many more
    not yet merged upstream), this makes it so that only *THREE* of
    them can hotplug ... versus in the current tree, essentially
    everything that's not a legacy driver is hotplugging just fine.

    That's one heck of a regression. Just shy of 100% ...

    Plus it treats rtc-ds1742 as if it's a platform_driver not
    an i2c_driver.

    - Dave

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-18 06:09    [W:8.764 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site