Messages in this thread |  | | | Date | Fri, 17 Aug 2007 15:09:57 +1000 | | From | Paul Mackerras <> | | Subject | Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures |
| |
Herbert Xu writes:
> Can you find an actual atomic_read code snippet there that is > broken without the volatile modifier?
There are some in arch-specific code, for example line 1073 of arch/mips/kernel/smtc.c. On mips, cpu_relax() is just barrier(), so the empty loop body is ok provided that atomic_read actually does the load each time around the loop.
Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |