lkml.org 
[lkml]   [2007]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/24] make atomic_read() behave consistently across all architectures
    Satyam Sharma wrote:

    >
    >On Fri, 17 Aug 2007, Nick Piggin wrote:
    >
    >
    >>Satyam Sharma wrote:
    >>
    >>It is very obvious. msleep calls schedule() (ie. sleeps), which is
    >>always a barrier.
    >>
    >
    >Probably you didn't mean that, but no, schedule() is not barrier because
    >it sleeps. It's a barrier because it's invisible.
    >

    Where did I say it is a barrier because it sleeps?

    It is always a barrier because, at the lowest level, schedule() (and thus
    anything that sleeps) is defined to always be a barrier. Regardless of
    whatever obscure means the compiler might need to infer the barrier.

    In other words, you can ignore those obscure details because schedule() is
    always going to have an explicit barrier in it.


    >>The "unobvious" thing is that you wanted to know how the compiler knows
    >>a function is a barrier -- answer is that if it does not *know* it is not
    >>a barrier, it must assume it is a barrier.
    >>
    >
    >True, that's clearly what happens here. But are you're definitely joking
    >that this is "obvious" in terms of code-clarity, right?
    >

    No. If you accept that barrier() is implemented correctly, and you know
    that sleeping is defined to be a barrier, then its perfectly clear. You
    don't have to know how the compiler "knows" that some function contains
    a barrier.


    >Just 5 minutes back you mentioned elsewhere you like seeing lots of
    >explicit calls to barrier() (with comments, no less, hmm? :-)
    >

    Sure, but there are well known primitives which contain barriers, and
    trivial recognisable code sequences for which you don't need comments.
    waiting-loops using sleeps or cpu_relax() are prime examples.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-17 13:55    [W:4.443 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site