![]() | |||||||||||||
Messages in this thread |
On Thursday August 16, jens.axboe@oracle.com wrote: > On Thu, Aug 16 2007, NeilBrown wrote:> > > > Almost every call to bio_data is for the first bio> > in a request. A future patch will add some accounting > > information to 'struct request' which will need to be > > used to find the start of the request in the bio.> > So replace bio_data with blk_rq_data which takes a 'struct request *' > > > > The one exception is in dm-emc were using> > page_address(bio->bi_io_vec[0].bv_page); > > is appropriate.> > This (and 3+4) just look like preparatory patches if we want to merge > the full patchset, not bug fixes. I seem to recall you had more bug > fixes or cleanups in your patchset, maybe I was mistaken. So nak for now > for 2-4, I'd apply 5 but it depends on the previous. > I don't remember other bug fixes, but I'll look through and check. 2 and 3 are very simple changes that - I think - make it clearer what is happening. And I felt 5 was a sufficient improvement to justify it and 4... I'll go hunting and see what other preliminaries I can find. NeilBrown - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2007-08-16 07:19 [from the cache] ©2003-2008 | |||||||||||||