Messages in this thread | | | Date | Thu, 16 Aug 2007 13:22:32 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH 002 of 5] Replace bio_data with blk_rq_data |
| |
On Thu, Aug 16 2007, Neil Brown wrote: > On Thursday August 16, jens.axboe@oracle.com wrote: > > > 2 and 3 are very simple changes that - I think - make it clearer what > > > is happening. > > > > To be honest, I don't see much win in using blk_rq_data() over > > bio_data() at all. I'd much much rather just see it go away! > > > > Well, as it is always the data at the (current) head of the request...
So is bio_data(bio), and bio_data(rq->bio) is by definition the head of the request. If anything, you are making it less flexible. Hence my suggestion to just kill it off completely, it's a long over due cleanup.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |