Messages in this thread | | | Date | Thu, 16 Aug 2007 13:19:03 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH 002 of 5] Replace bio_data with blk_rq_data |
| |
On Thu, Aug 16 2007, Neil Brown wrote: > On Thursday August 16, jens.axboe@oracle.com wrote: > > > 2 and 3 are very simple changes that - I think - make it clearer what > > > is happening. > > > > To be honest, I don't see much win in using blk_rq_data() over > > bio_data() at all. I'd much much rather just see it go away! > > > > Well, as it is always the data at the (current) head of the request... > > But I can make it go a way if you like.. What does it become? > bvec_kmap ??
Yeah, it then just becomes a kmap. And ->buffer goes away completely.
> > > And I felt 5 was a sufficient improvement to justify it and 4... > > > > 5 is nice, I would like to apply that :-) > > > > OK, here comes '5' at the top of a small set of patches. Take it and > any of the following that you like.
Thanks.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |