lkml.org 
[lkml]   [2007]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] seqfile: fix uninitialized memory allocation in mounts_open()
    On 8/15/07, Fengguang Wu <wfg@mail.ustc.edu.cn> wrote:
    > proc_mounts.m.buf is not explicitly zeroed at allocation time, which
    > may later confuse the seqfile code and triggle an kfree(m->buf).

    It's cleared in seq_open().

    > --- linux.orig/fs/proc/base.c
    > +++ linux/fs/proc/base.c
    > @@ -380,7 +380,7 @@ static int mounts_open(struct inode *ino
    >
    > if (ns) {
    > ret = -ENOMEM;
    > - p = kmalloc(sizeof(struct proc_mounts), GFP_KERNEL);
    > + p = kzalloc(sizeof(struct proc_mounts), GFP_KERNEL);
    > if (p) {
    > file->private_data = &p->m;
    > ret = seq_open(file, &mounts_op);
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-15 11:07    [W:0.023 / U:32.168 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site