lkml.org 
[lkml]   [2007]   [Aug]   [15]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [-mm PATCH 4/9] Memory controller memory accounting (v4)
DateWed, 15 Aug 2007 17:44:53 +0900 (JST)
From(YAMAMOTO Takashi)
> YAMAMOTO Takashi wrote:> >> +	lock_meta_page(page);> >> +	/*> >> +	 * Check if somebody else beat us to allocating the meta_page
> >> +	 */> >> +	race_mp = page_get_meta_page(page);> >> +	if (race_mp) {> >> +		kfree(mp);> >> +		mp = race_mp;> >> +		atomic_inc(&mp->ref_cnt);> >> +		res_counter_uncharge(&mem->res, 1);> >> +		goto done;> >> +	}> > > > i think you need css_put here.> > Thats correct. We do need css_put in this path.> > Thanks,> Vaidy
v5 still seems to have the problem.

YAMAMOTO Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-15 10:47    [from the cache]
©2003-2008