lkml.org 
[lkml]   [2007]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/3] x86_64 EFI runtime service support
    On Mon, 13 Aug 2007 15:30:19 +0800
    "Huang, Ying" <ying.huang@intel.com> wrote:

    > Following sets of patches add EFI/UEFI (Unified Extensible Firmware
    > Interface) runtime services support to x86_64 architecture.

    OK, we have a major trainwreck when these patches meet Peter's
    get-newsetup.patch.

    I'm halfway into fixing it when I see this. You have:

    #define SYS_DESC_TABLE (*(struct sys_desc_table_struct*)(PARAM+0xa0))
    +#define EFI_LOADER_SIG ((unsigned char *)(PARAM+0x1c0))
    +#define EFI_MEMDESC_SIZE (*((unsigned int *) (PARAM+0x1c4)))
    +#define EFI_MEMDESC_VERSION (*((unsigned int *) (PARAM+0x1c8)))
    +#define EFI_MEMMAP_SIZE (*((unsigned int *) (PARAM+0x1cc)))
    +#define EFI_MEMMAP (*((unsigned long *)(PARAM+0x1d0)))
    +#define EFI_SYSTAB (*((unsigned long *)(PARAM+0x1d8)))
    #define MOUNT_ROOT_RDONLY (*(unsigned short *) (PARAM+0x1F2))

    But Peter's include/asm-i386/bootparam.h has:

    struct efi_info {
    u32 _pad1;
    u32 efi_systab;
    u32 efi_memdesc_size;
    u32 efi_memdesc_version;
    u32 efi_memmap;
    u32 efi_memmap_size;
    u32 _pad2[2];
    };
    /* The so-called "zeropage" */
    struct boot_params {
    struct screen_info screen_info; /* 0x000 */
    struct apm_bios_info apm_bios_info; /* 0x040 */
    u8 _pad2[12]; /* 0x054 */
    struct ist_info ist_info; /* 0x060 */
    u8 _pad3[16]; /* 0x070 */
    u8 hd0_info[16]; /* obsolete! */ /* 0x080 */
    u8 hd1_info[16]; /* obsolete! */ /* 0x090 */
    struct sys_desc_table sys_desc_table; /* 0x0a0 */
    u8 _pad4[144]; /* 0x0b0 */
    struct edid_info edid_info; /* 0x140 */
    struct efi_info efi_info; /* 0x1c0 */
    u32 alt_mem_k; /* 0x1e0 */
    So for example, Peter has memdesc_size at 0x1c8 and you have it at 0x1c4.

    I'll give up and will drop the EFI patches. I'd suggest that you work with
    Peter on getting these patches integrated.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-16 01:19    [from the cache]
    ©2003-2014 Jasper Spaans. Advertise on this site